Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make symbolic indexing return VectorOfArray #466

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oscardssmith
Copy link
Contributor

This is a fairly minor change that makes things work more as expected.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #466 (7ff39ae) into master (f2eab6b) will increase coverage by 6.42%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   43.47%   49.90%   +6.42%     
==========================================
  Files          47       47              
  Lines        3558     3561       +3     
==========================================
+ Hits         1547     1777     +230     
+ Misses       2011     1784     -227     
Impacted Files Coverage Δ
src/ensemble/ensemble_solutions.jl 41.34% <0.00%> (-0.17%) ⬇️
src/solutions/solution_interface.jl 46.93% <33.33%> (+17.85%) ⬆️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member

test?

@oscardssmith
Copy link
Contributor Author

I think this is ready to go.

@@ -110,7 +110,7 @@ Base.@propagate_inbounds function Base.getindex(A::AbstractTimeseriesSolution, s
observed(A, sym, :)
end
elseif i isa Base.Integer || i isa AbstractRange || i isa AbstractVector{<:Base.Integer}
A[i, :]
VectorOfArray(A[i, :])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you know this is a vector of arrays?

@ChrisRackauckas
Copy link
Member

tests are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants