-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make symbolic indexing return VectorOfArray #466
base: master
Are you sure you want to change the base?
make symbolic indexing return VectorOfArray #466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 43.47% 49.90% +6.42%
==========================================
Files 47 47
Lines 3558 3561 +3
==========================================
+ Hits 1547 1777 +230
+ Misses 2011 1784 -227
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
test? |
I think this is ready to go. |
@@ -110,7 +110,7 @@ Base.@propagate_inbounds function Base.getindex(A::AbstractTimeseriesSolution, s | |||
observed(A, sym, :) | |||
end | |||
elseif i isa Base.Integer || i isa AbstractRange || i isa AbstractVector{<:Base.Integer} | |||
A[i, :] | |||
VectorOfArray(A[i, :]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you know this is a vector of arrays?
tests are failing. |
This is a fairly minor change that makes things work more as expected.